Skip to content

fix: Rename op db to db.query #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 23, 2025
Merged

fix: Rename op db to db.query #4444

merged 6 commits into from
Jun 23, 2025

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jun 5, 2025 •
edited
Loading

  • According to our span ops there is no op called just db, but we're emitting these from django, clickhouse, asyncpg and pymongo. Changing to db.query instead.
  • There was also a breadcrumb with type db that's also officially not a supported type, changed it to query.

This is intentionally just on potel-base since it's technically a breaking change.

@codecov Codecov
Copy link

codecov bot commented Jun 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (6d622b2) to head (4984c7f).
Report is 1 commits behind head on potel-base.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@              Coverage Diff               @@
##           potel-base    #4444      +/-   ##
==============================================
- Coverage       84.73%   84.72%   -0.01%     
==============================================
  Files             144      144              
  Lines           14821    14821              
  Branches         2365     2365              
==============================================
- Hits            12558    12557       -1     
  Misses           1539     1539              
- Partials          724      725       +1
Files with missing lines Coverage Δ
sentry_sdk/consts.py 99.59% <100.00%> (ø)
sentry_sdk/integrations/asyncpg.py 93.57% <ø> (ø)
sentry_sdk/integrations/clickhouse_driver.py 91.91% <ø> (ø)
sentry_sdk/integrations/django/__init__.py 84.50% <ø> (ø)
sentry_sdk/integrations/pymongo.py 85.96% <ø> (ø)
sentry_sdk/opentelemetry/utils.py 83.53% <100.00%> (ø)
sentry_sdk/tracing_utils.py 84.84% <ø> (ø)

... and 1 file with indirect coverage changes

@sentrivana sentrivana marked this pull request as ready for review June 5, 2025 07:52
@sentrivana sentrivana requested a review from a team as a code owner June 5, 2025 07:52
@sentrivana sentrivana merged commit 84187ea into potel-base Jun 23, 2025
127 of 129 checks passed
@sentrivana sentrivana deleted the ivana/fix-db-op branch June 23, 2025 09:56
sentrivana added a commit that referenced this pull request Jun 23, 2025
@sentrivana
Revert "fix: Rename op db to db.query (#4444)"
eb90689 
This reverts commit 84187ea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sentrivana @sl0thentr0py